On Tue, May 14, 2013 at 12:52:27PM -0400, Scott Talbert wrote: > On Sun, 28 Apr 2013, Scott Talbert wrote: > > > Here is a 3rd rev of the Windows patch. The changes in this rev are: > > A) Fix the project files so that the 'Release' version also builds. > > B) Fix a stack corruption issue with the WinHID code that I ran into while > > testing an MH remote under Windows. > > Phil, did you have any more comments on the Windows build fix patch (v3)? > If not, it could probably be merged?
Few questions/comments 1. You add a bunch of project files, as opposed to updating them... why? 2. You dropped support for a bunch of build environments which is fine, but a. we should remove the related project files b. we should not list "one of the following" in the readme if there's only one option :) 3. Why the extra abstraction in HID_WriteReport in winhid.cpp? -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
