On 06/24/2013 11:31 AM, Scott Talbert wrote: > I think I asked once before about replacing zzip with zip and you didn't > answer. :) I think I looked at just dumping the config without a zip > before but I think for MH, it would have made the config parsing a lot > more complicated (have to be able to parse both "official" .zips and our > unofficial format with the extra MH fields added). So, I think I would > prefer to just create a zip. My approach would be to do this in parts - > leave this part as adding MH config dumping and then do a second patch to > convert the rest of the code to libzip and remove zzip. Unless you would > prefer it be done in one patch?
So, to your point about the code, could we just detect if it's zip'd and then unzip, and otherwise handle it identically? If that just adds one if statement rather than having to handle the two files in completely different ways I think it's a win... it gets us to supporting this with no additional requirements, and then we can look at replacing zzip with zip in a follow up diff. If not, but we want to replace zip with zzip, I'm OK with that, I'm just loathe to temporarily add an additional dependency. We could make a branch for mh-config-dumping and work there until we had the whole thing done, but it's still be multiple patches... though I prefer the previous suggestion more. -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
