On Mon, 24 Jun 2013, Phil Dibowitz wrote: > Also, in some of the patches from this weekend I forgot the "From:" header, > but since you have the first Signed-off-by header, it should be clear who it > came from.
I think that if I send you patches using "git format-patch" and you apply them with "git am" it will automatically add an "Author:" field to the commit. Would you prefer I do that? Alternatively, I could just create a fork on Sourceforge and push stuff there. You could then add my fork as a remote and pull things directly. Do you think that would be a better workflow? > I haven't had a chance to look at your MH config dumping patch yet. We should > also talk about whether we want to replace the usage of zzip with zip. > Requiring both seems unwise. Alternatively, we could say that we just don't > zip the dumped file... since we're the only software that reads it (and > there's plenty of other things we don't do to those files that the website > does), that's not completely unreasonable. I think I asked once before about replacing zzip with zip and you didn't answer. :) I think I looked at just dumping the config without a zip before but I think for MH, it would have made the config parsing a lot more complicated (have to be able to parse both "official" .zips and our unofficial format with the extra MH fields added). So, I think I would prefer to just create a zip. My approach would be to do this in parts - leave this part as adding MH config dumping and then do a second patch to convert the rest of the code to libzip and remove zzip. Unless you would prefer it be done in one patch? ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
