On Sat, Feb 18, 2012 at 03:52:02PM +1030, David Kettler wrote: > This version uses the same technique as the former "stack&strut" > method, but wraps it up in an "annotated-textbox" XBL binding. > Implementing the binding is much longer than the former patch which > included the new elements directly into the minibuffer; this is mainly > due to the verbosity of XBL. But the usage of the annotation in > hints_info is very neat. > > This has been (lightly) tested in xulrunner 1.9.1, 10.0 and 11.0. > > Thanks again for your suggestions, John. > > Regards, David
Looking good; thank you! I've pushed the patches to the branch 'inline-url-panel' for a review and testing phase. Hopefully we can get some community participation on this, because it's a major change. I was laughing at the comments about XML.. XML isn't human-readable, it's human-scrutable :) But on the whole I think this is a very nice way to implement the feature, very clean implementation in hints.js and the affected minibuffer code, and as clean as it gets in the XBL - if nothing else, it's well-defined. Maybe we should start another thread for community review of the branch, to help keep the ml tidy. -- John Foerch _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
