On Sat, Feb 25, 2012 at 05:35:03PM +1030, David Kettler wrote: > This pair of commits implements John's suggestion to enable this > feature using modes. It's a nice approach. > > Further discussion on naming of the functions might be better in the > review thread.
I like the names you've chosen for the modes. They make it obvious what their purpose is. The minibuffer-annotation system is of course a general system by design, so let's say down the road we add another feature that uses it - for example, ido-style inline completions. This poses a problem, because if this hypothetical feature were enabled, and a person then disabled hints-minibuffer-annotation-mode, minibuffer-annotation-mode should *not* be disabled, because it is still needed for the inline completions system. Any thoughts on how to deal with this eventuality? -- John Foerch _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
