Hi Josh,

> > > When using the D-Bus API I've found that both Device and Manager have a
> > > property each where when using SetProperty they return an invalid
> > > arguments error when setting the property to the same value as is
> > > already set.
> > > 
> > > This seems a bit draconian so I've attached a patch to return silently
> > > instead.
> > 
> > Of course, it doesn't build and I didn't check before sending.
> > What an idiot ...
> 
> Correct patch attached

it is still wrong. You can't just return NULL here. You need to return a
proper success message.

Also we are using tabs and you used something else. Coding style, coding
style ;)

Question still is if we really want this. Is this a desired behavior of
the API. Does it makes things a lot simpler?

Regards

Marcel


_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to