Hi Patrik,
On Sat, Nov 27, 2010 at 09:55:39PM +0200, [email protected] wrote:
> From: Patrik Flykt <[email protected]>
>
> The __connman_agent_report_error function creates and sends a ReportError
> method call to the registered agent. The agent can reply with D-Bus error
> net.connman.Agent.Error.Retry if the same service is to be retried.
The patch looks good, I just have a couple of comments about it:
> +struct report_error_reply {
> + struct connman_service *service;
> + report_error_cb_t callback;
> + void *user_data;
> +};
> +
> +static void report_error_return(DBusPendingCall *call, void *user_data)
For consistency sake, I'd prefer to have this one called report_error_reply,
and use report_error_data for the structure.
> +{
> + struct report_error_reply *report_error = user_data;
> + DBusMessage *reply = dbus_pending_call_steal_reply(call);
> + gboolean retry = FALSE;
> + const char *dbus_err;
> +
> + if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) {
Nothing to change here, but I just want to say that this is not my favorite
way of requesting a retry from ConnMan. This is not an error after all, and
imo a regular D-Bus message would make more sense.
I'll still take it since it seems BlueZ and oFono are doing the same, so I'd
rather be consistent here as well.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
