Hi Patrik, On Sat, Nov 27, 2010 at 09:55:36PM +0200, [email protected] wrote: > From: Patrik Flykt <[email protected]> > > Hi, > > This patch set implements Agent API ReportError method call. v2 is updated to > use D-Bus name net.connman. Thanks for that.
> Error names have been updated to use an net.connman.Agent prefix, as object > paths were found not to be a valid component in an error name. A > 'service_complete' helper function has been created, it is needed later on in > the patch set. > > __connman_agent_report_error has been implemented taking a callback function > and user data argument. A ReportError method call is created and sent, and > the specified Error.Retry D-Bus error is used to decide whether to retry the > same service or not. > > The error reporting functionality is triggered from service.c for a service > state set to CONNMAN_SERVICE_STATE_FAILURE. Error strings are created with > error2string, please comment if such use of the existing error names is ok. That is fine, yes. > Also the bottom half of __connman_service_indicate_state after the > 'service_complete' function is run every time, also on a retry. I haven't > seen any problems so far with my limited testing, other people with > better knowledge may want to take another look whether that's sane or not. I've added some comments for that on the corresponding patch. The patchset looks almost fine, I just mostly had some nitpicks about it, and one concern about our service change D-Bus signal. See my patch reviews. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
