Hi Daniel,

On Tue, Apr 19, 2011 at 11:19:58AM +0200, Daniel Wagner wrote:
> >>  int connman_inet_set_mtu(int index, int mtu);
> >>  int connman_inet_setup_tunnel(char *tunnel, int mtu);
> >> +int connman_inet_create_tunnel(char **iface);
> > That should be included with the previous patch. I haven't tried, but I'm
> > quite sure the build breaks if you don't apply this patch and the following
> > one.
> > 
> > I understand you want (and deserve) to get credits for your work here. I
> > suggest you keep Gustavo's patch for the TUN interface creation, and then 
> > add
> > yours on top of it that does that: Moving this API to inet.c and fixing the
> > callers.
> 
> BTW, I think connman_inet_*_tunnel should be reused at one point for
> plugins/vpn.c.
Yes, that's exactly what I had in mind when I asked Gustavo for that.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to