https://bugs.contribs.org/show_bug.cgi?id=10760

--- Comment #7 from Jean-Philippe Pialasse <[email protected]> ---
(In reply to mab974 from comment #5)
> (In reply to Jean-Philippe Pialasse from comment #3)
> > Created attachment 6184 [details]
> > /etc/e-smith/templates-custom/etc/rc.d/init.d/masq/90adjustXt_Geoip
> 
> In
> /sbin/iptables -A \$NEW_XTGeoIP -m geoip ! --src-cc $locBC -p tcp --dport
> $port -j DROP\n
> 
> "!" allows all BadCountries ? (same in 40Xt_Geoip)
> 
the idea here is to allow only those countries, instead of ban the country,
hence the ! before the option.

maybe we can also propose the option to choose between exclude (no !) or
include (with !) behaviours. However, I would keep it simple for the moment.

> the test 
> if ($GP eq 'enabled' and $BC ne '')
> differs from  40Xt_Geoip


(In reply to mab974 from comment #6)
> the message at the end 
> "or no 'BadCountries' defined"
> does not fit the test any more


indeed need to change the output of the else and add a new one

thanks for your time

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
_______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/

Reply via email to