On 11 Jan 2003, Pixel wrote:
>
> i'd still say i have not much time for this, but i'm ready to accept
> patches.
>
I haven't got a patch, but can I make a request while you're hacking? I
haven't tested install yet, but I don't think this buglet has been fixed:
(cc'ing to Sly, and Stew who did the initial implementation)
In this code block in install_any.pm:
write_smb_conf($domain);
run_program::rooted($o->{prefix}, "chkconfig", "--level", "35",
"winbind", "on");
mkdir_p("$o->{prefix}/home/$domain");
Please ensure $domain is capitalised before creating the directory. You
capitalise a bit later:
sub write_smb_conf {
my ($domain) = @_;
$domain =~ tr/a-z/A-Z/;
Where you could capitalise immediately after getting from the user:
my $domain = $o->{netc}{WINDOMAIN};
(The capitalisation of the domain name in smb.conf isn't necessary, but
winbind always returns %D in caps, and we use 'template homedir =
/home/%D/%U', pam_mkhomedir does the %U on login, so we just need $domain
capitalised)
Also, optionally, install could use the /etc/samba/smb-winbind.conf
currently in samba-common (might get this moved into samba-winbind
instead) instead of inlining the configuration file pieces. But that's not
so important, and it works as is. One idea may be to replace the workgroup
line in /etc/samba/smb-winbind.conf anyway if the minimal inline is kept,
so users wanting a more normal config (printers shared by default for
example) have an easy way to do so? Anyway, your decision.
Then maybe you can remove me from the source:
#- was going to just have a canned config in samba-winbind
#- and replace the domain, but sylvestre/buchan didn't bless it yet
Buchan
--
|----------------Registered Linux User #182071-----------------|
Buchan Milne Mechanical Engineer, Network Manager
Cellphone * Work +27 82 472 2231 * +27 21 8828820x121
Stellenbosch Automotive Engineering http://www.cae.co.za
GPG Key http://ranger.dnsalias.com/bgmilne.asc
1024D/60D204A7 2919 E232 5610 A038 87B1 72D6 AC92 BA50 60D2 04A7
