[ 
https://issues.apache.org/jira/browse/HADOOP-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hemanth Yamijala updated HADOOP-3304:
-------------------------------------

    Attachment: 3304.patch

Attached patch fixes the following:
- Moves the shell shebang to the top of the file
- Modifies the default value of the log destination to '/user'
- Modifies the regular expression for looking up files, to be restricted to 
files under hod-logs only. This will also narrow the scope of search greatly, 
and should be much faster.
- Adds a try...except block so that a single problematic file won't stop 
logcondense.py.

> [HOD] logcondense fails if DFS has files that are not log files, but match a 
> certain pattern
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3304
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3304
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>    Affects Versions: 0.16.2
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Critical
>         Attachments: 3304.patch
>
>
> logcondense works by listing files in dfs and match them against a certain 
> pattern. This pattern is incorrect in the sense that it can potentially match 
> files that are not log files. And this can cause it to fail and not delete 
> files correctly as it should.
> It should use a correct regular expression that will only list log files. 
> Also, possibly it should log a stack trace if it happens, but continue to 
> delete files and not stop.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to