[ 
https://issues.apache.org/jira/browse/HADOOP-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592293#action_12592293
 ] 

Vinod Kumar Vavilapalli commented on HADOOP-3304:
-------------------------------------------------

   * Tested to check that it now only searches in <prefix>/*/hod-logs for 
purging.
   * We should have documentation for logcondense, describing what/how it does, 
and its usage; currently we don't have any documentation.
   * Hudson's "tests included -1" message: Not writing any test cases.(for now?)
   * Found some bugs and good to have enhancements to logcondense. Filing 
separate issues.

+1 for the fix in general.

> [HOD] logcondense fails if DFS has files that are not log files, but match a 
> certain pattern
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3304
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3304
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>    Affects Versions: 0.16.2
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3304.patch
>
>
> logcondense works by listing files in dfs and match them against a certain 
> pattern. This pattern is incorrect in the sense that it can potentially match 
> files that are not log files. And this can cause it to fail and not delete 
> files correctly as it should.
> It should use a correct regular expression that will only list log files. 
> Also, possibly it should log a stack trace if it happens, but continue to 
> delete files and not stop.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to