[
https://issues.apache.org/jira/browse/HADOOP-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592142#action_12592142
]
Hadoop QA commented on HADOOP-3304:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380854/3304.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2317/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2317/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2317/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2317/console
This message is automatically generated.
> [HOD] logcondense fails if DFS has files that are not log files, but match a
> certain pattern
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-3304
> URL: https://issues.apache.org/jira/browse/HADOOP-3304
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hod
> Affects Versions: 0.16.2
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Critical
> Attachments: 3304.patch
>
>
> logcondense works by listing files in dfs and match them against a certain
> pattern. This pattern is incorrect in the sense that it can potentially match
> files that are not log files. And this can cause it to fail and not delete
> files correctly as it should.
> It should use a correct regular expression that will only list log files.
> Also, possibly it should log a stack trace if it happens, but continue to
> delete files and not stop.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
