[ https://issues.apache.org/jira/browse/HADOOP-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635084#action_12635084 ]
Hadoop QA commented on HADOOP-4226: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12391039/HADOOP-4226.patch against trunk revision 699517. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3384/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3384/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3384/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3384/console This message is automatically generated. > LineReader::readLine cleanup > ---------------------------- > > Key: HADOOP-4226 > URL: https://issues.apache.org/jira/browse/HADOOP-4226 > Project: Hadoop Core > Issue Type: Improvement > Components: mapred > Affects Versions: 0.19.0 > Reporter: Yuri Pradkin > Assignee: Yuri Pradkin > Priority: Minor > Attachments: HADOOP-4226.patch > > > I've been looking at HADOOP-4010 and realized that readLine is pretty > convoluted. I changed the implementation which made it hopefully a little > easier to read/validate/understand. > I've had some problems testing it locally, so I'll submit it for Hudson to > test. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.