[
https://issues.apache.org/jira/browse/HADOOP-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635086#action_12635086
]
Chris Douglas commented on HADOOP-4226:
---------------------------------------
* A quick note on policy: old patches are not deleted, as they orphan the
discussion about them.
* The improvements to TestTextInputFormat are very good; thanks for these
* This is clearer and better documented than the existing code. However, in
reviewing corner cases, the reasoning was sometimes unclear (e.g. deferring the
increment of bytesConsumed for CR (clever, by the way)). If this could include
a short summary of the strategy employed and a few more comments, it would be
more readily understandable the next time a change is proposed.
* CR and LF should be final, as in the previous patch
With a little more documentation, I think this is good to commit.
> LineReader::readLine cleanup
> ----------------------------
>
> Key: HADOOP-4226
> URL: https://issues.apache.org/jira/browse/HADOOP-4226
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Yuri Pradkin
> Assignee: Yuri Pradkin
> Priority: Minor
> Attachments: HADOOP-4226.patch
>
>
> I've been looking at HADOOP-4010 and realized that readLine is pretty
> convoluted. I changed the implementation which made it hopefully a little
> easier to read/validate/understand.
> I've had some problems testing it locally, so I'll submit it for Hudson to
> test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
