[ 
https://issues.apache.org/jira/browse/HADOOP-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664095#action_12664095
 ] 

Vinod K V commented on HADOOP-2721:
-----------------------------------

+1 for the patch. Can a committer have a look at this and give a code review? 
Devaraj?

Few miscelleneous points:
 - With this patch, everytime a new task is launch, its pid file is written. 
This is another trip to disk at task startup and so this needs benchmarking. 
Ravi is on a short vacation, so i'll try to see if I can run a benchmark myself.
 - This patch brings job control for task startup for both java tasks and by 
default to streaming. For pipes, we still need some work, I propose it to be 
done in another JIRA if nobody else have any objection to this.
 - We also need patches for the previous versions starting from 0.18.

> Use job control for tasks (and therefore for pipes and streaming)
> -----------------------------------------------------------------
>
>                 Key: HADOOP-2721
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2721
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/streaming, mapred, pipes
>            Reporter: Owen O'Malley
>            Assignee: Ravi Gummadi
>         Attachments: HADOOP-2721-v10.patch, HADOOP-2721-v2.patch, 
> HADOOP-2721-v3.patch, HADOOP-2721-v9.patch, HADOOP-2721.patch, 
> HADOOP-2721.patch, HADOOP-2721.patch
>
>
> We should use the setsid command when the task is launched to create a new 
> session. We should be able to use the setsid program when we launch the bash 
> process to create a new session. That will allow us to kill the entire 
> session with a single signal and remove the need for the ping methods in both 
> TaskTracker.Child and pipes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to