[
https://issues.apache.org/jira/browse/HADOOP-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665581#action_12665581
]
Chris Douglas commented on HADOOP-5023:
---------------------------------------
A few procedural nits: per the
[guidelines|http://wiki.apache.org/hadoop/HowToContribute], please use tabs
instead of spaces, don't modify CHANGES.txt in the patch (this is done by the
committer; otherwise, it will conflict with other patches), and commented-out
code should be removed (ProxyFilter.java, build.xml).
I have no knowledge of Tomcat, so someone else should evaluate that, but
generally:
* Defaults from the configuration are the second actual in the call, so:
{noformat}
+ String nn = conf.get("hdfsproxy.dfs.namenode.address");
+ if (nn == null) {
+ nn = "hdfs://localhost:50888";
+ }
{noformat}
is equivalently: {{conf.get("hdfsproxy.dfs.namenode.address",
"hdfs://localhost:50888")}}. That said, the default should not be localhost. If
this is for testing, the test should set this in the configuration, and- Kan,
please correct this if it's mistaken- the proxy should throw if this parameter
is undefined.
* If src/web/cactus-web.xml is required for testing, it should be in src/test,
not src/web. I'm not sure I understand how it's used; none of its parameters
are referenced in the unit test...
* Attempting to run the unit test causes compilation failures on my machine
({{ant -Dtestcase=TestProxyFilter test}}):
{noformat}
BUILD FAILED
/snip/hadoop/build.xml:750: The following error occurred while executing this
line:
/snip/hadoop/src/contrib/build.xml:48: The following error occurred while
executing this line:
/snip/hadoop/src/contrib/hdfsproxy/build.xml:239:
/snip/hadoop/src/contrib/hdfsproxy/${env.HDFSPROXY_CONF_DIR} not found.
{noformat}
> Add Tomcat support to hdfsproxy
> -------------------------------
>
> Key: HADOOP-5023
> URL: https://issues.apache.org/jira/browse/HADOOP-5023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hdfsproxy
> Reporter: Kan Zhang
> Assignee: zhiyong zhang
> Attachments: HADOOP-5023.patch
>
>
> We plan to add Tomcat support to hdfsproxy since Tomcat has good production
> support at Yahoo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
