[
https://issues.apache.org/jira/browse/HADOOP-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665606#action_12665606
]
zhiyong zhang commented on HADOOP-5023:
---------------------------------------
Thanks Chris for your quick review.
1. I am following the http://wiki.apache.org/hadoop/HowToContribute to make the
changes. In http://wiki.apache.org/hadoop/HowToContribute, there is one line
"Indent two spaces per level, not four." I didn't find place that tell me to
use tab instead of space. Also, I thought I was supposed to modify CHANGES.txt,
as stated in the guidelines. Maybe there are some other guidlines that are not
written in that link. I will remove the commented-out code in ProxyFilter.java
and build.xml.
2. I agree with you that conf.get("hdfsproxy.dfs.namenode.address",
"hdfs://localhost:50888") is more compact. I am not sure whether we should
throw exception on this or set default. that part of code is in ProxyFilter's
init() function, which implements Filter interface's init() function. In Fiter
interface init() only throws ServletException. But seems our type of Exception
is IOException. I am not sure it is appropriate or even legal to throw a
ServletException in this case. Note that this part of code was not for testing.
Which default value should I use if I am not supposed to use localhost?
3. I agree that src/web/cactus-web.xml should be moved to src/test as it is
only used for unit testing. The way it works is when you run unit test cactus
will merge src/web/cactus-web.xml with your web.xml to generate a new web.xml,
which set up all the redirect serlets, etc, for in-container testing. That is
done automatically by cactus framework.
4. I've written the instruction on README.txt. you need to export
HADOOP_CONF_DIR and HDFSPROXY_CONF_DIR correctly before you run ant war and ant
test. I think you didn't set up HDFSPROXY_CONF_DIR envionment, that is what it
complains about.
Thanks.
> Add Tomcat support to hdfsproxy
> -------------------------------
>
> Key: HADOOP-5023
> URL: https://issues.apache.org/jira/browse/HADOOP-5023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hdfsproxy
> Reporter: Kan Zhang
> Assignee: zhiyong zhang
> Attachments: HADOOP-5023.patch
>
>
> We plan to add Tomcat support to hdfsproxy since Tomcat has good production
> support at Yahoo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
