[ 
https://issues.apache.org/jira/browse/HADOOP-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665648#action_12665648
 ] 

Chris Douglas commented on HADOOP-5023:
---------------------------------------

bq. I didn't find place that tell me to use tab instead of space. Also, I 
thought I was supposed to modify CHANGES.txt, as stated in the guidelines.

*nod* Sun's conventions explicitly don't specify whether tabs are excluded, but 
they are. I'll change the wiki to omit the reference to CHANGES.txt, thanks for 
pointing that out.

bq. I am not sure whether we should throw exception on this or set default. 
[snip] Which default value should I use if I am not supposed to use localhost?

Setting the cause of the ServletException as an IOException (or even just 
throwing the ServletException) seems like the correct behavior to me. Kan has 
the context for this, so he can say whether it's an error for this parameter to 
be undefined.

bq. I've written the instruction on README.txt. you need to export 
HADOOP_CONF_DIR and HDFSPROXY_CONF_DIR correctly before you run ant war and ant 
test. I think you didn't set up HDFSPROXY_CONF_DIR envionment, that is what it 
complains about.

Ah, I see. Unfortunately, this requires HDFSPROXY_CONF_DIR to be set to run 
"{{ant test}}", a prerequisite that cannot be committed.

> Add Tomcat support to hdfsproxy
> -------------------------------
>
>                 Key: HADOOP-5023
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5023
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hdfsproxy
>            Reporter: Kan Zhang
>            Assignee: zhiyong zhang
>         Attachments: HADOOP-5023.patch
>
>
> We plan to add Tomcat support to hdfsproxy since Tomcat has good production 
> support at Yahoo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to