[
https://issues.apache.org/jira/browse/HADOOP-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711913#action_12711913
]
Konstantin Shvachko commented on HADOOP-5188:
---------------------------------------------
# Isn't that supposed to belong to HADOOP-5832?
# I don't understand why you need the LoggingDevice? It is just a wrapper
around the configuration variable, which is now a URI.
So you can just create edits streams based on the URI itself rather than on
different types of LoggingDevice-s.
You currently instantiate LoggingDevice-s based on the URI's so you may as well
instantiate directly the streams based on that.
# I would suggest to move StorageDirectory directly inside
EditLogFileOutputStream rather than LoggingDevice. This might be a separate
issue.
# Do you also plan to make "dfs.name.dir" a URI. Looks like you cannot avoid
that since if "dfs.name.edits.dir" is not specified then "dfs.name.dir"
automatically become edits directories as well as name dirs.
> Modifications to enable multiple types of logging
> --------------------------------------------------
>
> Key: HADOOP-5188
> URL: https://issues.apache.org/jira/browse/HADOOP-5188
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.20.0
> Reporter: Luca Telloli
> Fix For: 0.21.0
>
> Attachments: HADOOP-5188.patch, HADOOP-5188.patch, HADOOP-5188.patch,
> HADOOP-5188.patch, HADOOP-5188.pdf
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
