[ 
https://issues.apache.org/jira/browse/HADOOP-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712406#action_12712406
 ] 

Flavio Paiva Junqueira commented on HADOOP-5188:
------------------------------------------------

I'd like to make a comment and ask a question:

1- There are two files missing license headers. Before submitting a patch, 
please make sure that all new files have a license header. Also, according to 
Hudson, this patch introduces new potential bugs according to findbugs. Pleas 
verify if they can be fixed;

2- Using BookKeeper as an example, I was wondering where we will store the 
configuration parameters necessary to bootstrap and run it as a log device. For 
example, we need to specify number of bookies and ledger mode. If I understand 
it correctly, the idea is to pass these parameters in a URI, and then parse the 
URI. Once the namenode parses the URI, it will have the values for the 
corresponding variables, and it will keep it somewhere. Is the idea to keep 
such configuration parameters in the corresponding log device implementation 
for BookKeeper?


 

> Modifications to enable multiple types of logging 
> --------------------------------------------------
>
>                 Key: HADOOP-5188
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5188
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Luca Telloli
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5188.patch, HADOOP-5188.patch, HADOOP-5188.patch, 
> HADOOP-5188.patch, HADOOP-5188.pdf
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to