On Fri, Mar 26, 2010 at 11:36, Ulf Zibis <ulf.zi...@gmx.de> wrote: > Am 24.03.2010 00:50, schrieb Martin Buchholz: >> >> I've added another mini-patch to my patch set. >> >> http://cr.openjdk.java.net/~martin/webrevs/openjdk7/isBMPCodePoint3 >> >> This deletes Surrogate.java, as Ulf wants, >> except that ... it's another variant of Surrogate.java! >> (which I didn't know existed) >> >> Uses of Surrogate.neededFor are all now changed to >> Character.isSupplementaryCodePoint, as suggested by Ulf. >> >> I intend to fold all of the isBMPCodePoint patches together into one >> before I commit them. >> >> Ulf, please review. >> > > Looking at my old patch: > https://bugs.openjdk.java.net/attachment.cgi?id=148&action=diff, > I'm afraid, that there are some remaining references to Surrogate class in > the code base: > - cold imports > - static final constants > Can you declude them in your patch?
OK, just to make you happy, more Surrogate cleansing. Two more mini-patches for you to review: To be qfolded into public-isBMPCodePoint http://cr.openjdk.java.net/~martin/webrevs/openjdk7/isBMPCodePoint4 to be qfolded into highSurrogate http://cr.openjdk.java.net/~martin/webrevs/openjdk7/highSurrogate2 Martin