Am 27.03.2010 00:18, schrieb Martin Buchholz:
On Fri, Mar 26, 2010 at 11:36, Ulf Zibis<ulf.zi...@gmx.de> wrote:
Looking at my old patch:
https://bugs.openjdk.java.net/attachment.cgi?id=148&action=diff,
I'm afraid, that there are some remaining references to Surrogate class in
the code base:
- cold imports
- static final constants
Can you declude them in your patch?
OK, just to make you happy, more Surrogate cleansing.
Two more mini-patches for you to review:
To be qfolded into public-isBMPCodePoint
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/isBMPCodePoint4
Looks good.
Maybe you could rename isBMPCodePoint* to public-isBMPCodePoint*
I often mix, that isBMPCodePoint seems to be precedent of isBMPCodePoint*
to be qfolded into highSurrogate
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/highSurrogate2
You additionally could add:
* Use of {...@link Character#high/lowSurrogate} is generally preferred.
and propagate those methods to Character class.
-Ulf
