Hi Amy,

On 17/09/2014 1:49 AM, Amy Lu wrote:
Some java/lang/invoke/lambda tests have dependency on sun.tools.jar.Main
This fix is to remove above internal JDK API dependency from the tests.

bug: https://bugs.openjdk.java.net/browse/JDK-8058569
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058569/webrev.01/

I'm a little confused as to the issue here. Running the jar tool programmatically as a Java program doesn't seem like a big deal, but if it is then just run the the jar tool directly (this test is a JDK-only test either way); or remove the static dependency with reflection based code. Plus the same code still has this dependency:

     static final com.sun.tools.javac.Main javac =
              new com.sun.tools.javac.Main();

so I don't see that anything is being gained at the moment.

Is there a bigger picture that this is part of?

Thanks,
David

Thanks,
Amy

Reply via email to