On 9/17/2014 8:37 AM, Alan Bateman wrote:
On 17/09/2014 16:29, Amy Lu wrote:
Hi, David
Thank you for your review!
Here's the updated version, run jar tool directly:
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058569/webrev.02/
com.sun.tools.javac.Main is not reported as internal API so far (see
below jdeps result before the fix), if this changed in the future, it
will be fixed in a separate bug.
com.sun.tools.javac.Main is a supported API so it will need to be
exported when we move to module.
A good way to determine if an API is exported or not (before the module
system is further along):
check out http://hg.openjdk.java.net/jdk9/dev/file/d1d2ca914d49/modules.xml:
<module>
<name>jdk.compiler</name>
...
<export>
<name>com.sun.tools.javac</name>
</export>
...
</module>
Mandy
