On 17/09/2014 16:29, Amy Lu wrote:
Hi, David
Thank you for your review!
Here's the updated version, run jar tool directly:
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058569/webrev.02/
com.sun.tools.javac.Main is not reported as internal API so far (see
below jdeps result before the fix), if this changed in the future, it
will be fixed in a separate bug.
com.sun.tools.javac.Main is a supported API so it will need to be
exported when we move to module. The standard API is of course
javax.tools but I don't think there is a need to change these tests to
use that.
The jar tool never had a supported API so if tests don't strictly need
to use sun.tools.jar directly then it would be good to eliminate that
dependency.
-Alan.
