> On Nov 15, 2016, at 4:04 PM, David DeHaven <david.deha...@oracle.com> wrote: > > >>>> Please review the (fairly straightforward) JDK changes needed to support >>>> launching JavaFX applications in a named module. >>>> >>>> JBS: >>>> https://bugs.openjdk.java.net/browse/JDK-8169289 >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~ddehaven/8169289/jdk.0/ >>>> >>>> >>> >>> Would it be better to refactor line 557-563 and 612-624 and be called in >>> the checkAndLoadMain method after the main class is loaded? >> >> Yeah, we probably could do that. I'll look into it. > > Updated with your suggested change: > http://cr.openjdk.java.net/~ddehaven/8169289/jdk.1
Looks fine. I wonder what appClass is intended for and whether it should be set in line 483 instead. 554 appClass = c; 600 // record the main class 601 appClass = mainClass; Kumar would know the history. Mandy
