>>>>>> Please review the (fairly straightforward) JDK changes needed to support 
>>>>>> launching JavaFX applications in a named module.
>>>>>> 
>>>>>> JBS:
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8169289
>>>>>> 
>>>>>> Webrev:
>>>>>> http://cr.openjdk.java.net/~ddehaven/8169289/jdk.0/
>>>>>> 
>>>>>> 
>>>>> 
>>>>> Would it be better to refactor line 557-563 and 612-624 and be called in 
>>>>> the checkAndLoadMain method after the main class is loaded?
>>>> 
>>>> Yeah, we probably could do that. I'll look into it.
>>> 
>>> Updated with your suggested change:
>>> http://cr.openjdk.java.net/~ddehaven/8169289/jdk.1
>> 
>> Looks fine.  I wonder what appClass is intended for and whether it should be 
>> set in line 483 instead.
>> 
>> 554         appClass = c;
>> 
>> 600         // record the main class
>> 601         appClass = mainClass;
>> 
>> Kumar would know the history.
> 
> It was added as part of the original work to support launching FX 
> applications in JDK 8, it's primarily for error reporting so it reports the 
> correct main class instead of FXHelper.
> 
> You are correct in that it should have been moved too.. I'll update that when 
> I get back.

Round 3:
http://cr.openjdk.java.net/~ddehaven/8169289/jdk.2

Tested with a jar that had a bad JavaFX-Application-Class and it continued to 
report the correct class name.

-DrD-

Reply via email to