Ping for review.

(or should I withdraw this change and leave the set LC_ALL related tests as shell script tests as they are?)

Thanks,
Amy

On 6/7/17 2:14 PM, Amy Lu wrote:
java/nio/charset/Charset/default.sh
java/nio/charset/coders/CheckSJISMappingProp.sh
java/nio/file/Path/MacPathTest.java which runs shell test:
     * @run shell MacPathTest.sh

Please review this patch to refactor these shell tests to java.

Note that in MacPathTest.sh, it requires the test to be run with LC_ALL=en_US.UTF-8 env. But unlike the other two tests, LC_ALL settings here is just to setup an env in order for the test to work correctly, it’s not the locale it intends to test.

bug: https://bugs.openjdk.java.net/browse/JDK-8181395
webrev: http://cr.openjdk.java.net/~amlu/8181395/webrev.00/

Thanks,
Amy

Reply via email to