Hi Joe and Daniel > > So far so good, most of them still seem to be present in > > your changes, but I have a doubt about these two: > > > > https://bugs.openjdk.java.net/browse/JDK-8062608 > > https://bugs.openjdk.java.net/browse/JDK-8064516 > > > > Has the issue been fixed upstream in a different way, or > > is the issue no longer relevant, or is it going to appear > > again with this patch? > > Good catch! The original patch came from BCEL, so I indeed assumed this > update would get things the right way. As I double-checked, it turns out > the additional patches as you listed above fixed issues that BCEL 6.0 > hasn't. These issues were revealed by JRocket, did not affect JAXP, > however, they are still good changes that we shall keep. I've gone > through both of the above to put these changes back into the code. >
Advertising
IIUC JDK-8062608 and JDK-8064516 are related to JDK-8003147 but for JRocket, the first webrev(http://cr.openjdk.java.net/~joehw/jdk10/8163121/webrev/) looks different with the fix of JDK-8003147, however we have the relevant test in the repo, i.e. http://hg.openjdk.java.net/jdk9/jdk9/jaxp/file/tip/test/javax/xml/jaxp/unittest/parsers/Bug8003147Test.java, since all tests were passed, I assume the first webrev worked for JDK-8003147, certainly the second webrev looks good too :) Thanks Frank
