On Wed, Sep 27, 2017 at 1:44 PM, Doug Lea <d...@cs.oswego.edu> wrote:
> On 09/27/2017 02:38 PM, Paul Sandoz wrote: > >> Looks good, i just need to look a little more closely at the > ConcurrentSkipListMap changes. > >> > > > > > > 328 * Note that, with VarHandles, a boolean result of > > 329 * compareAndSet must be declared even if not used. > > This should not be necessary, since for such methods the return is not > polymorphic. Did you observe some performance or code generation issues? > > > > It was necessary at the time I started rewriting this in June, > but apparently not now. I'll get rid of the annoying unnecessary > declarations. Thanks to whoever fixed this! The latest webrev no longer has the unneeded boolean locals.