I have moved the CSR [1] back to Draft and updated it according to the content of webrev.03. If there are no more comments by tomorrow I will move it once again to Finalized. After that, once the CSR has been re-approved, then if there are no further comments on the changes I will go ahead and push the fix, assuming there are no unexpected failures in rerunning the regression tests.
Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8194956 On Jan 24, 2018, at 1:06 PM, Roger Riggs <roger.ri...@oracle.com> wrote: > +1 > > On 1/24/2018 2:50 PM, Brian Burkhalter wrote: >> On Jan 23, 2018, at 4:50 PM, Brian Burkhalter <brian.burkhal...@oracle.com> >> wrote: >> >>> On Jan 23, 2018, at 1:19 AM, Weijun Wang <weijun.w...@oracle.com> wrote: >>> >>>> + * Therefore, the method may be safely called with very large values >>>> of >>>> + * {@code len} provided sufficient memory is available. >>>> >>>> What does "sufficient memory" mean? For len, or the number of available >>>> bytes? >>> >>> It means enough bytes for the collectivity of the intermediate and returned >>> buffers. This is already stated to be proportional to ‘len’. >> >> All right, to make sure this horse is truly dead here’s one more revision. >> The changes with respect to the previous revision are [1] and the overall >> changes versus the SCM base are [2]. The .02-.03 differences are: >> >> A) Add an @implNote at line 368. >> B) Minor memory use improvement at line 392. >> >> Thanks, >> >> Brian >> >> [1] http://cr.openjdk.java.net/~bpb/8139206/webrev.02-03/ >> [2] http://cr.openjdk.java.net/~bpb/8139206/webrev.03/