Hi Bhaktavatsal Reddy, thanks for addressing this long standing issue. I've opened "8201540: [AIX] Extend the set of supported charsets in java.base" [1] to track this issue.
As I wrote in the bug report, this problem is the consequence of an emergency fix (JDK-8081332) I did back in 2015 to fix the build on AIX after the integration of the modularity support change (see discussion: [2]). At that time I only added the minimal set of charsets which were required to fix the build. It would be great if you can get in touch with your IBM colleagues to find out which are the default extended charsets supported by IBM J9 on AIX. I think we should try to use a similar set here in our OpenJDK port which is also used by the OpenJ9 for building OpenJ9 on AIX. Also, your IBM colleagues can help you to host a webrev which will make the further review of these changes much easier. I've but Tim from IBM on CC which should have an overview of all the IBM people involved in the OpenJDK project. Besides that I know at least the following people who might help you: Michihiro Horie: ho...@jp.ibm.com Hiroshi H Horii: ho...@jp.ibm.com Gustavo Romero: grom...@linux.vnet.ibm.com Matthew Brandyberyy: mbra...@linux.vnet.ibm.com Thank you and best regards, Volker [1] https://bugs.openjdk.java.net/browse/JDK-8201540 [2] http://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005431.html On Fri, Apr 13, 2018 at 2:42 PM, Bhaktavatsal R Maram <bhama...@in.ibm.com> wrote: > Hi Alan, > > Thank you for your response. I'm happy that my patch was attached. But, I > don't see attachment. So, I inlined patch which contain diffs from 2 > changesets in mail text. If a Jira bug is opened for this issue, probably I > can attach complete and consolidated patch there. > > At high level, I'm adding following charsets to standard charset in > java.base. For this, I have to change IBM943C and IBM942C from source to > template to handle java package and aliases. It is also required to add > codepage 932 as alias for IBM942C because both are one and same. > > Big5, Big5_HKSCS, GB18030, IBM942, IBM942C, IBM943, IBM943C, IBM950, IBM970, > IBM1124, TIS_620 > > > These are default charsets for some of locales supported by Operating System > (AIX). Since these are not available in standard charset, JDK can't be used > in those locale even if they are available in jdk.charset module (java > -version fails). > > I've followed some of the discussions around this in community and understand > that default charset of a locale should be made available in java.charset > module by using stdcs-* mechanism. On Linux, they were added to java.base in > similar way. As it is missing for AIX, I've added them to enable JDK support > for more locales. > > > Thanks, > Bhaktavatsal Reddy > > -----Alan Bateman <alan.bate...@oracle.com> wrote: ----- > To: Bhaktavatsal R Maram <bhama...@in.ibm.com>, core-libs-dev@openjdk.java.net > From: Alan Bateman <alan.bate...@oracle.com> > Date: 04/13/2018 03:52PM > Subject: Re: Missing many locales support on AIX platform > > On 13/04/2018 10:35, Bhaktavatsal R Maram wrote: >> Given that patch is big, I am sending patch as attachment again after >> changing some mail settings. Hopefully, it will make to community this time. > Your patch was attached. > > If I read it correctly, you've switched IBM943C to a template but there > aren't additional aliases so this part is effectively a no-op, is that > right? For IBM932C, you've moved it to be template and added several > aliases. > > The rest is AIX specific and I hope the SAP engineers that maintain the > AIX port can help you. It may be that you are testing with locales that > aren't supported configurations for the AIX port in OpenJDK. As a > general point, we try to keep as many of the exotic and multibyte > charsets out of java.base. They are of course still available to > applications via the API and the jdk.charsets service provider module. > > -Alan > >
