Hi Bhaktavatsal Reddy, you change looks good, although I can't really verify all the charset aliases. For example Wikipedia mentions that "ibm-932" is equivalent to "ibm-942" [1] but you made it an alias for "ibm-942C". What's actually the difference between "ibm-942C" and "ibm-942"?
I can sponsor your change although I would appreciate if somebody else from IBM could have another look at your change. I tried to compare with "IBM Java 9" but it doesn't seem to exist. They only refer to AdoptOpenJDK and AdoptOpenJDK just uses a vanilla version of OpenJDK. Finally, I hope you won't mind if I update the copyright years on the files you changed before pushing (this is a convention in the OpenJDK project). Best regards, Volker [1] https://en.wikipedia.org/wiki/Code_page_932_(IBM) On Mon, Apr 16, 2018 at 1:10 PM, Bhaktavatsal R Maram <bhama...@in.ibm.com> wrote: > Hi All, > > I've regenerated webrev using "hg rename" to create template files. webrev > looks much neat now.. Thanks Alan for suggestion. > > webrev - http://cr.openjdk.java.net/~gromero/8201540/v2/ > > Thanks, > Bhaktavatsal Reddy > > > -----"core-libs-dev" <core-libs-dev-boun...@openjdk.java.net> wrote: ----- > To: Alan Bateman <alan.bate...@oracle.com> > From: "Bhaktavatsal R Maram" > Sent by: "core-libs-dev" > Date: 04/16/2018 02:38PM > Cc: Tim Ellison <tim_elli...@uk.ibm.com>, ppc-aix-port-...@openjdk.java.net, > Java Core Libs <core-libs-dev@openjdk.java.net> > Subject: Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in > java.base > > Hi Alan, > > I deleted IBM943C.java (using hg remove) and added new file > IBM943C.java.template (using hg add). I now understand that using "hg rename" > is giving more meaningful representation in webrev/index.html. > > I will re-generate webrev by renaming source files to templates using "hg > rename" > > Thanks, > Bhaktavatsal Reddy > > > > -----Alan Bateman <alan.bate...@oracle.com> wrote: ----- > To: Bhaktavatsal R Maram <bhama...@in.ibm.com>, Volker Simonis > <volker.simo...@gmail.com> > From: Alan Bateman <alan.bate...@oracle.com> > Date: 04/16/2018 02:16PM > Cc: Java Core Libs <core-libs-dev@openjdk.java.net>, Tim Ellison > <tim_elli...@uk.ibm.com>, ppc-aix-port-...@openjdk.java.net > Subject: Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in > java.base > > > On 16/04/2018 09:22, Bhaktavatsal R Maram wrote: >> >> 3. Source files for IBM-942C and IBM-943C are changed to template to support >> #1 >> > You might want to double check the webrev as it looks like you've added > templates where as I assume you mean to use "hg rename" to rename > IBM942C.java and IBM943C.java. > > -Alan > > >
