Hi All, I've regenerated webrev using "hg rename" to create template files. webrev looks much neat now.. Thanks Alan for suggestion.
webrev - http://cr.openjdk.java.net/~gromero/8201540/v2/ Thanks, Bhaktavatsal Reddy -----"core-libs-dev" <core-libs-dev-boun...@openjdk.java.net> wrote: ----- To: Alan Bateman <alan.bate...@oracle.com> From: "Bhaktavatsal R Maram" Sent by: "core-libs-dev" Date: 04/16/2018 02:38PM Cc: Tim Ellison <tim_elli...@uk.ibm.com>, ppc-aix-port-...@openjdk.java.net, Java Core Libs <core-libs-dev@openjdk.java.net> Subject: Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base Hi Alan, I deleted IBM943C.java (using hg remove) and added new file IBM943C.java.template (using hg add). I now understand that using "hg rename" is giving more meaningful representation in webrev/index.html. I will re-generate webrev by renaming source files to templates using "hg rename" Thanks, Bhaktavatsal Reddy -----Alan Bateman <alan.bate...@oracle.com> wrote: ----- To: Bhaktavatsal R Maram <bhama...@in.ibm.com>, Volker Simonis <volker.simo...@gmail.com> From: Alan Bateman <alan.bate...@oracle.com> Date: 04/16/2018 02:16PM Cc: Java Core Libs <core-libs-dev@openjdk.java.net>, Tim Ellison <tim_elli...@uk.ibm.com>, ppc-aix-port-...@openjdk.java.net Subject: Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base On 16/04/2018 09:22, Bhaktavatsal R Maram wrote: > > 3. Source files for IBM-942C and IBM-943C are changed to template to support > #1 > You might want to double check the webrev as it looks like you've added templates where as I assume you mean to use "hg rename" to rename IBM942C.java and IBM943C.java. -Alan
