Hello Bob, > Hi Bob, > no problem , we can wait a few days until the final version of Win > server > 2019 is out, and check the buildNumber again : >
seems Windows server 2019 is GA now : https://cloudblogs.microsoft.com/windowsserver/2018/10/02/windows-server-2019-now-generally-available/ > > We don’t usually add logic to the JDK related to unreleased operating system > > previews. so I think we can process with the review . Still have to find out the buildNumber of the GA version, probably it has been incremented again . Best regards, Matthias > -----Original Message----- > From: Baesken, Matthias > Sent: Dienstag, 2. Oktober 2018 17:03 > To: Bob Vandette <bob.vande...@oracle.com> > Cc: hotspot-...@openjdk.java.net; core-libs-dev@openjdk.java.net; > Moldenhauer, Niclas <niclas.moldenha...@sap.com> > Subject: RE: RFR : 8211106: [windows] Update OS detection code to > recognize Windows Server 2019 > > Hi Bob, > no problem , we can wait a few days until the final version of Win > server > 2019 is out, and check the buildNumber again : > > https://cloudblogs.microsoft.com/windowsserver/2018/09/24/windows- > server-2019-announcing-general-availability-in-october/ > > says : > "In October, customers will have access to Windows Server 2019 through all > the channels! > We will publish a blog post to mark the availability of Windows Server 2019 > soon." > > > > > > The latest preview release is build 17744. Are you testing on that release? > > > > I was testing on a system with build number 17677 ( Windows Server 2019 > preview , seems older than what you are seeing) > and 17723 . > > > Best regards, Matthias > > > > -----Original Message----- > > From: Bob Vandette <bob.vande...@oracle.com> > > Sent: Dienstag, 2. Oktober 2018 16:09 > > To: Baesken, Matthias <matthias.baes...@sap.com> > > Cc: hotspot-...@openjdk.java.net; core-libs-dev@openjdk.java.net; > > Moldenhauer, Niclas <niclas.moldenha...@sap.com> > > Subject: Re: RFR : 8211106: [windows] Update OS detection code to > > recognize Windows Server 2019 > > > > Matthias, > > > > We don’t usually add logic to the JDK related to unreleased operating > system > > previews. > > > > Has the ReleaseID been updated on the system you are testing on? > > > > This is the documented way of determining the OS version you are running > > on? > > > > The latest preview release is build 17744. Are you testing on that release? > > > > https://techcommunity.microsoft.com/t5/Windows-Server- > > Insiders/Windows-Server-2019-version-info/td-p/234472 > > > > > > Bob. > > > > > > > On Oct 2, 2018, at 9:01 AM, Baesken, Matthias > > <matthias.baes...@sap.com> wrote: > > > > > > Hello, please review change 8211106 . > > > > > > It updates the Windows OS detection code to recognize Windows > Server > > 2019 . > > > > > > For this we have to look at the build number (dwBuildNumber of > > OSVERSIONINFOEX), > > > > > > https://docs.microsoft.com/en-us/windows/desktop/api/Winnt/ns- > winnt- > > _osversioninfoexa > > > > > > > > > because dwMajorVersion and dwMinorVersion are the same for > > Windows server 2016 and 2019 . > > > > > > The build number used to compare ( 17677 ) is for Windows Server 2019 > > preview , most likely the final version will have a higher build number > > but > > this is fine for the coding . > > > > > > > > > Bug/webrev : > > > > > > https://bugs.openjdk.java.net/browse/JDK-8211106 > > > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.0/webrev/ > > > > > > > > > Thanks, Matthias
