Hi Matthias, thanks for opening the bug. I refined its description a little...
Best regards Christoph > -----Original Message----- > From: Alan Bateman <[email protected]> > Sent: Mittwoch, 6. Februar 2019 10:00 > To: Langer, Christoph <[email protected]>; Baesken, Matthias > <[email protected]> > Cc: [email protected] > Subject: Re: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > > On 29/01/2019 08:58, Langer, Christoph wrote: > > Hi Matthias, > > > >>> New webrev : > >>> > >>> > >>> http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.4/ > >> This is the one. Looks good ( and clean ). > > I agree, this version would be ok for me to be pushed. It would be good > ,though, if there was a test for this (long paths on Windows). > > > > I also like Alan's suggestion to open a follow up bug to explore using > CreateFile on Windows right away rather than trying open. Looking at > libjava/libnet/libnio, it's all CreateFileW on Windows... > I think the right fix is to convert a relative path into absolute path, > apply the prefix for long paths, and then use CreateFileW consistently. > It's probably okay to get there in steps but I can't tell from the > current webrev if it works with relative paths or not. > > -Alan
