On 3/7/19 3:17 PM, Mandy Chung wrote:
Lastly, I'm sorry to see you weren't happy with the quality of my test
code. Your changes seem much larger in scale, and quite different to
my changes. Could you explain the benefits of your approach, vs simply
adding non-static final fields to my code?
First, I dont see my test update is large scale. Second, it's not
about the quality of the test code. The size of the change is not
the sole factor to consider but that seems to bother you. Anyway,
the test itself isn't easy to work with. You have done the fix to
include the regression test which is okay.
BTW one other main purpose I propose my patch is to show you an example
that proposing this change (that you consider larger in scale) does not
take months to approve. I should make this explicit.
Mandy
