Hi Mandy, Good spot. Have updated the webrev.
http://cr.openjdk.java.net/~afarley/8216558/webrev/ Could you review the proposed change? Also, I ran the invoke tests as advised, and the only one that fails is "LFGarbageCollectedTest.java", which also fails in the same way when run against a non-patched java, so I think we're ok. Best Regards Adam Farley IBM Runtimes Mandy Chung <mandy.ch...@oracle.com> wrote on 20/03/2019 05:08:37: > From: Mandy Chung <mandy.ch...@oracle.com> > To: Adam Farley8 <adam.far...@uk.ibm.com> > Cc: core-libs-dev <core-libs-dev@openjdk.java.net> > Date: 20/03/2019 05:10 > Subject: Re: RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails > to throw IllegalAccessException for final fields > > Hi Adam, > > I imported your patch but there is one test failure: > > test/jdk/java/lang/invoke/VarHandles/accessibility/ > TestFieldLookupAccessibility.java > > This test needs update of this change. Can you please send an updated > patch and run all test/jdk/java/lang/invoke tests. > > Mandy > > On 3/6/19 8:28 AM, Adam Farley8 wrote: > > Hi Mandy, > > > > The webrev has been updated with the new test: > > https://urldefense.proofpoint.com/v2/url? > u=http-3A__cr.openjdk.java.net_-7Eafarley_8216558_webrev_&d=DwIC- > g&c=jf_iaSHvJObTbx-siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=O5CP6Q1HCaWGgNnRJQd_nB-y- > yzhE9tMJCTaqP-Sezo&s=2pU2OPf0uzVxxO95vYcq37aYknofgj2TKansTE2chyY&e= > > > > Note that I included a handful of small improvements, and that the final > > fields are all setAccessible by default, because (a) it seemed cleaner > > than adding a new control bit, and (b) nobody is meant to be changing > > final fields anyway. > > > > Open for review. > > > > Best Regards > > > > Adam Farley > > IBM Runtimes > Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
