Hi Julia, I think the fix is fine overall
I noticed that the copyright was not updated in all of the files modified, which may be OK in this case, but I typically change it when I made minor changes as well. Not a big deal. The only other question is I am wondering if we want to align the text better with the rest of the javadocs (maybe a separate bug) as for example you look at ZipOutputStream.java, the change on line 144 is slightly off. Its not a big deal but a minor hiccup from probably using a script which is understandable HTH lance > On Sep 5, 2019, at 6:59 AM, Julia Boes <julia.b...@oracle.com > <mailto:julia.b...@oracle.com>> wrote: > > ..this time with the right link! > > > On 05/09/2019 11:40, Julia Boes wrote: >> Hi, >> >> This change replaces all occurrences of the @exception tag in java.base with >> the @throws tag. The tags are synonyms but @throws is the newer preferred >> option [1]. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8230648 >> <https://bugs.openjdk.java.net/browse/JDK-8230648> > Webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8230648/webrev.00/ > <http://cr.openjdk.java.net/~dfuchs/jboes/8230648/webrev.00/> >> >> >> >> Regards, >> >> Julia >> >> [1] >> https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#throws >> >> <https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#throws> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
