Hi Julia, It looks fine., thank you for doing this
Best Lance > On Sep 5, 2019, at 2:28 PM, Julia Boes <julia.b...@oracle.com> wrote: > > Hi, > > Thanks for your comments, Lance and Pavel. > > The copyright will be updated before pushing, as Daniel suggested. > > To address the tag alignment, I adjusted the replacement from '@exception' -> > '@throws' to '@exception' -> 'throws ', where the added whitespace > preserves the original alignment. This doesn't improve the alignment (which > is not consistent in many places) but at least doesn't make it worse. > > Updated webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8230648/webrev.02/ > > Regarding Pavel's comment: > > 8157682: @inheritDoc doesn't work with @exception > > I ran specdiff on the whole JDK and it didn't flag any differences but I'll > look into additional comparison options. > > Cheers, > > Julia > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
