Hi Chris,

The changes don't appear incorrect, but at least from a cursory inspection, they don't appear as precise as they could be. Usually generifying a classes like this will next yield a round of redundant "cast" warnings; in my cleanup efforts, getting cast warnings was usually a sign the right generifiation was found.

HTH,

-Joe

On 3/25/2020 12:57 AM, Chris Yin wrote:
Hello

Please review following simple changes to cleanup raw types warning for open 
jndi tests (under test/jdk/com/sun/jndi and test/jdk/javax/naming), thanks

Bug: https://bugs.openjdk.java.net/browse/JDK-8214694
Webrev: http://cr.openjdk.java.net/~xyin/8214694/webrev.00/


The changes should be straightforward, only fix raw types warnings, no test 
logic change, no code optimization or cleanup. Minor change to each test file, 
just a little surprised about the affected tests count, hope this covers all. 
Run related jndi tests on 4 platforms for total 200 times, all passed.

Thanks,
Chris

Reply via email to