Thank you, Vyom Regards, Chris
> On 27 Mar 2020, at 6:06 PM, Vyom Tiwari <vyomm...@gmail.com> wrote: > > Hi Chris, > > Latest changes look good to me. I can see that there are couple of unused > imports in files(DeadServerTimeoutSSLTest.java) but unused imports are > separate issue. > > Thanks, > Vyom > > On Fri, Mar 27, 2020 at 2:48 PM Chris Yin <xu.y....@oracle.com > <mailto:xu.y....@oracle.com>> wrote: > Hi, Vyom > >> On 27 Mar 2020, at 12:08 PM, Vyom Tiwari <vyomm...@gmail.com >> <mailto:vyomm...@gmail.com>> wrote: >> >> Hi Chris, >> >> I have one question to you, is there is any specific reason for using >> wildcard(?) ?. > > Thank you for reviewing and comments. I just replaced most of the wildcard(?) > with specified type as precise as they could be in latest webrev.01, the rest > of them may fall into below scenarios. > > 1. API return value or parameter with wildcard(?), such as Hashtable<?,?> in > test/jdk/com/sun/jndi/dns/EnvTests/AddInherited.java > 2. Cannot find the precise type from code, such as ScheduledFuture<?> in > test/jdk/com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java > >> In your change we can avoid "?" at most of the places. Please see the below >> methods signatures. >> >> ####################################################################### >> public NamingEnumeration<Binding> listBindings(Name name) throws >> NamingException; >> public NamingEnumeration<NameClassPair> list(Name name) throws >> NamingException; >> public NamingEnumeration<SearchResult> search(Name name, Attributes >> matchingAttributes, >> >> String[] attributesToReturn) throws NamingException; >> ##################################################################### > > Thank you for the detailed signatures info, yes, now all fixed in the latest > webrev http://cr.openjdk.java.net/~xyin/8214694/webrev.01/ > <http://cr.openjdk.java.net/~xyin/8214694/webrev.01/> > > Regards, > Chris > >> >> thanks, >> Vyom >> >> On Wed, Mar 25, 2020 at 1:28 PM Chris Yin <xu.y....@oracle.com >> <mailto:xu.y....@oracle.com>> wrote: >> Hello >> >> Please review following simple changes to cleanup raw types warning for open >> jndi tests (under test/jdk/com/sun/jndi and test/jdk/javax/naming), thanks >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214694 >> <https://bugs.openjdk.java.net/browse/JDK-8214694> >> Webrev: http://cr.openjdk.java.net/~xyin/8214694/webrev.00/ >> <http://cr.openjdk.java.net/~xyin/8214694/webrev.00/> >> >> >> The changes should be straightforward, only fix raw types warnings, no test >> logic change, no code optimization or cleanup. Minor change to each test >> file, just a little surprised about the affected tests count, hope this >> covers all. Run related jndi tests on 4 platforms for total 200 times, all >> passed. >> >> Thanks, >> Chris >> >> >> -- >> Thanks, >> Vyom > > > > -- > Thanks, > Vyom
