Hi Chris,

I have one question to you, is there is any specific reason for using
wildcard(?) ?.
In your change we can avoid  "?" at most of the places. Please see the
below methods signatures.

#######################################################################
public NamingEnumeration<Binding> listBindings(Name name)  throws
NamingException;
public NamingEnumeration<NameClassPair> list(Name name)  throws
NamingException;
public NamingEnumeration<SearchResult>    search(Name name,  Attributes
matchingAttributes,


String[] attributesToReturn)  throws NamingException;
#####################################################################

thanks,
Vyom

On Wed, Mar 25, 2020 at 1:28 PM Chris Yin <xu.y....@oracle.com> wrote:

> Hello
>
> Please review following simple changes to cleanup raw types warning for
> open jndi tests (under test/jdk/com/sun/jndi and test/jdk/javax/naming),
> thanks
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214694
> Webrev: http://cr.openjdk.java.net/~xyin/8214694/webrev.00/
>
>
> The changes should be straightforward, only fix raw types warnings, no
> test logic change, no code optimization or cleanup. Minor change to each
> test file, just a little surprised about the affected tests count, hope
> this covers all. Run related jndi tests on 4 platforms for total 200 times,
> all passed.
>
> Thanks,
> Chris



-- 
Thanks,
Vyom

Reply via email to