On Wed, 25 Nov 2020 12:16:01 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass in thread instead of rematerializing it.
>
> src/hotspot/cpu/x86/universalNativeInvoker_x86.cpp line 33:
>
>> 31:
>> 32: void ProgrammableInvoker::Generator::generate() {
>> 33: #ifdef _LP64
>
> Instead of introducing ifdefs, I'd prefer to see
> `universalNativeInvoker_x86.cpp` split into
> `universalNativeInvoker_x86_64.cpp` (current code) and
> `universalNativeInvoker_x86_32.cpp` (populated with dummy impelmentations).
Yeah, makes sense. The old code had ifdefs, but splitting seems cleaner to me
as well.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1266
