On Wed, 25 Nov 2020 00:01:47 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> commits since the last revision: >> >> - Merge branch 'master' into Linker_32bit-fixes_Simpler >> - Remove JNI_ENTRY_CPP_NOENV >> - - Move reset_last_Java_frame >> - Use the Unimplemented() macro instead of hlt() >> - Merge branch 'master' into Linker_32bit-fixes_Simpler >> - Remove UnsupportedPlatform test >> - Remove unneeded cast >> - Remove Stuff that makes the jdk_foreign tests pass >> - fix test warnings >> - - Fix 32-bit build errors and tests >> - Add negative test for 32-bit platform. >> - Change CABI to fail more lazily when running on an unsupported platform. >> - Change CLinker layouts to be null on unsupported platforms, instead of >> failing when initializing the class >> - Added note to CLinker about failure to initialize on unsupported >> platforms > > The VM "entry" changes seem better now. Thanks. > > The use of CATCH as a safety-net is also good. I've applied open comments. Please let me know if this is ok to merge. ------------- PR: https://git.openjdk.java.net/jdk/pull/1266
