On Tue, 17 Nov 2020 17:19:13 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
> JDK-8254231 breaks the Linux and Windows x86 (32-bit) builds. This contains > the needed changes to get it working again. > > Perhaps the most interesting change is adding the `JNI_ENTRY_CPP_NOENV` > macro. Using just JNI_ENTRY was causing a linkage failure, due to the > declaration of the function in the class not having the same linkage > specifiers. It looks like we can't just specify C linkage for class member > functions. > > However, in this case C linkage is not required, so I've added the new macro > which doesn't have `extern "C"`. I've also dropped the `JNIEnv*` parameter, > since it was not being used, but causing extra work for the caller. > > Other than that, it's just about adding default definitions for missing > functions, and moving around some code in MacroAssembler to be in the correct > `#ifdef` blocks. > > Testing: `make images` on Linux and Windows x86_32 platforms. This pull request has now been integrated. Changeset: 7c73fff3 Author: Jorn Vernee <jver...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/7c73fff3 Stats: 88 lines in 12 files changed: 45 ins; 27 del; 16 mod 8256486: Linux/Windows-x86 builds broken after JDK-8254231 Reviewed-by: shade ------------- PR: https://git.openjdk.java.net/jdk/pull/1266
