On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa <github.com+34924738+mahendrachh...@openjdk.org> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. test/jdk/java/lang/Class/forName/NonJavaNames.java line 67: > 65: @BeforeClass > 66: public void createInvalidNameClasses() throws IOException { > 67: Path hyphenPath = Paths.get(TEST_SRC + "hyphen.class"); Building a `Path` with string concatenation is an anti-pattern. Also `Path.of` is probably preferred instead of `Paths.get`. ------------- PR: https://git.openjdk.java.net/jdk/pull/2170