On Mon, 1 Feb 2021 20:27:00 GMT, Mahendra Chhipa <github.com+34924738+mahendrachh...@openjdk.org> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. Thanks for the update. This is much cleaner. test/jdk/java/lang/Class/forName/NonJavaNames.java line 154: > 152: @DataProvider(name = "badNonJavaClassNames") > 153: Object[][] getBadNonJavaClassNames() { > 154: return new Object[][] {{";"}, {"["}, {"."}}; Nit: one line per test (i.e. make it multiple lines) test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 42: > 40: > 41: /* > 42: * @test Nit: suggest to move this comment block to the top before all imports. ------------- Marked as reviewed by mchung (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2170
